Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use testify instead of t.Fatal or t.Error in pkg package (part 1) #18970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use testify instead of t.Fatal or t.Error in pkg package (part 1) #18970

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 30, 2024 •
edited
Loading

Description

This uses testify instead of testing for t.Fatal or t.Error calls in pkg package

Related to #18972

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35 mmorel-35 force-pushed the testifier/pkg branch 2 times, most recently from 2678692 to 03192b6 Compare November 30, 2024 13:52
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (39d9cd7) to head (0a71106).

Additional details and impacted files

see 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18970      +/-   ##
==========================================
+ Coverage   68.77%   68.82%   +0.04%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
+ Hits        24500    24516      +16     
+ Misses       9699     9684      -15     
+ Partials     1424     1423       -1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d9cd7...0a71106. Read the comment docs.

@mmorel-35 mmorel-35 mentioned this pull request Nov 30, 2024
Open
14 tasks
@ahrtr
Copy link
Member

ahrtr commented Dec 4, 2024

/ok-to-test

@mmorel-35
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorel-35
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @k8s-ci-robot @ahrtr